YAS 227 L2-to-L1 Message Receiver #44
Conversation
| uint nonce | ||
| ); | ||
|
|
||
| struct EnqueuedL2ToL1Message { |
There was a problem hiding this comment.
If this will be passed between multiple contracts, should we put it in DataTypes.sol?
There was a problem hiding this comment.
As far as I can tell, it is only gonna show up here, so that's where I put it.
|
|
||
| struct EnqueuedL2ToL1Message { | ||
| dt.L2ToL1Message message; | ||
| uint blockEnqueued; |
| } | ||
|
|
||
| address public trustedSequencer; | ||
| uint public messageDelay; |
| blockEnqueued: blockNum | ||
| }); | ||
| messageNonce += 1; | ||
| emit L2ToL1MessageEnqueued( |
There was a problem hiding this comment.
Will the event have a blocknum accessible by default? Also, will we want the nonce in this?
There was a problem hiding this comment.
good catch, that was supposed to be the nonce!
| } | ||
|
|
||
| function verifyL2ToL1Message(dt.L2ToL1Message memory _message, uint _nonce) public view returns (bool) { | ||
| // The enqueued message at the given nonce mudt match the _message being verified |
There was a problem hiding this comment.
| // The enqueued message at the given nonce mudt match the _message being verified | |
| // The enqueued message at the given nonce must match the _message being verified |
| uint blockEnqueued; | ||
| } | ||
|
|
||
| address public trustedSequencer; |
There was a problem hiding this comment.
How do you feel about removing the word trusted? My rationale is that it's implied and may draw unnecessary negative attention.
This is a little tricky, since the context for this contract is that it is really there to " simulate" what an actual rollup contract would do. And in that context, the messages can't be removed--but they also don't appear on the main chain other than implicitly via a state root. So for now, I think I'm not gonna add that ability as it would be deprecated quickly anyway. |
…down-lint Add markdown linting and formatting with markdownlint
Description
Implements YAS 227, L2-to-L1 message receiver in a trusted context to build out dev ex.
Questions
Metadata
Fixes
Contributing Agreement