Making all base yarn actions act on all packages including integration tests #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckages including tests
gakonst
added a commit
that referenced
this pull request
Apr 12, 2021
* feat(l2geth): sequencer fee pricing ethereum-optimism/go-ethereum#273 ethereum-optimism/go-ethereum#306 ethereum-optimism/go-ethereum#305 * test(l1-l2-comms): fund l2 address before starting the test * test(rpc): ensure that fee paid grows with data size * test: add helper class for instantiation optimistic envs * refactor: use the env container for l1<>l2 tests * refactor: use the env container for queue ingestion and proxy tests * fix(erc20-test): take fee payments into account * refactor: use the env container for fee payment tests * refactor: use the env container for native eth tests
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* feat(l2geth): sequencer fee pricing ethereum-optimism/go-ethereum#273 ethereum-optimism/go-ethereum#306 ethereum-optimism/go-ethereum#305 * test(l1-l2-comms): fund l2 address before starting the test * test(rpc): ensure that fee paid grows with data size * test: add helper class for instantiation optimistic envs * refactor: use the env container for l1<>l2 tests * refactor: use the env container for queue ingestion and proxy tests * fix(erc20-test): take fee payments into account * refactor: use the env container for fee payment tests * refactor: use the env container for native eth tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before integration tests were not included in yarn [clean | build | test | fix | lint | all]. This PR makes it so that they are, providing isolated core vs integration test tasks where necessary.
Contributing Agreement