Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-service/metrics: Add subsystem to event metrics #5407

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Apr 10, 2023

Description

Adds the subsystem back to event metrics.

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

⚠️ No Changeset found

Latest commit: 029566b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 029566b
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64349e9ea6afd00008df9dfa

@trianglesphere trianglesphere marked this pull request as ready for review April 10, 2023 23:43
@trianglesphere trianglesphere requested a review from a team as a code owner April 10, 2023 23:43
@trianglesphere trianglesphere requested review from mslipper and ajsutton and removed request for mslipper April 10, 2023 23:43
@sebastianst sebastianst merged commit 536340c into develop Apr 11, 2023
@sebastianst sebastianst deleted the jg/metrics_cleanup branch April 11, 2023 19:16
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

Hey @trianglesphere, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants