Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-batcher,proposer: Default previously required flags #5510

Merged
merged 2 commits into from
Apr 25, 2023
Merged

op-batcher,proposer: Default previously required flags #5510

merged 2 commits into from
Apr 25, 2023

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Apr 20, 2023 •
edited
Loading

Description
This provides default values for the following flags

  • poll-interval
  • sub-safety-margin

These flags are likely to be overridden by users, but they do not have to be and we can provide sensible defaults rather than requiring them.

Metada

TODOs

@trianglesphere
op-batcher,proposer: Default previously required flags
d35c733 
This provides default values for the following flags
* poll-interval
* sub-safety-margin

These flags are likely to be overridden by users, but they do not have to
be and we can provide sensible defaults rather than requiring them.
@trianglesphere trianglesphere requested a review from a team as a code owner April 20, 2023 18:50
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 98291fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 98291fb
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64483b86af749300086f836a

@trianglesphere trianglesphere requested review from sebastianst and ajsutton and removed request for mslipper April 21, 2023 16:49
@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Apr 25, 2023
@mergify mergify bot removed the conflict label Apr 25, 2023
@sebastianst sebastianst merged commit 57c008e into develop Apr 25, 2023
@sebastianst sebastianst deleted the jg/flags branch April 25, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianst sebastianst sebastianst approved these changes

@ajsutton ajsutton Awaiting requested review from ajsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trianglesphere @sebastianst