Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deposited tx type RLP encoding specs #5559

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: deposited tx type RLP encoding specs #5559

merged 2 commits into from
Apr 28, 2023

Conversation

merklefruit
Copy link
Contributor

Description

The RLP order in the specs was not consistent with the code.

Metadata

TODOs

@merklefruit merklefruit requested review from a team as code owners April 28, 2023 09:10
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63f02f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 63f02f9
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/644bc8f215a0320008b344ef

tynes
tynes reviewed Apr 28, 2023
View reviewed changes
specs/deposits.md Outdated Show resolved Hide resolved
trianglesphere
trianglesphere approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@trianglesphere trianglesphere merged commit 34175ef into ethereum-optimism:develop Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes left review comments

@trianglesphere trianglesphere trianglesphere approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts smartcontracts is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@ajsutton ajsutton Awaiting requested review from ajsutton ajsutton is a code owner automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question on Deposited transaction type RLP encoding specs
3 participants
@merklefruit @tynes @trianglesphere