Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pops): Challenger Metrics #5604

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 4, 2023

Description

This PR adds metrics to the challenger service.

Challenger metrics is nearly identical to the proposer service, with the following additional endpoints. (More can be added in future prs, but these are the core data series we should collect to track the challenger service).

RecordValidOutput(l2ref eth.L2BlockRef)
RecordInvalidOutput(l2ref eth.L2BlockRef)
RecordOutputChallenged(l2ref eth.L2BlockRef)

Background

Building off #5568, this PR introduces new changes to the op-challenger service.

The op-challenger is a naive, honest challenge agent that can be run as a standalone service for permissionless output proposal validation.

In the initial iteration of PoPs, only a permissioned set of challenge agents can dispute outputs as part of the Attestation Dispute Game. But once Fault Dispute Games are implemented, disputing outputs will be permissionless.

Metadata

Fixes CLI-3943

@refcell refcell self-assigned this May 4, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

⚠️ No Changeset found

Latest commit: 90d4275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 90d4275
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64540274f050ab0008357b4e

@refcell refcell changed the title Introduce metrics for the op-challenger. feat(pops): Challenger Metrics May 4, 2023
@refcell refcell force-pushed the refcell/challenger/metrics branch from ce52173 to 50caa1a Compare May 4, 2023 16:24
@semgrep-app
Copy link

semgrep-app bot commented May 4, 2023

Semgrep found 1 no-fprintf-to-responsewriter finding:

  • proxyd/tools/mockserver/handler/handler.go: L76

Detected 'Fprintf' or similar writing to 'http.ResponseWriter'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package to render data to users.

Created by no-fprintf-to-responsewriter.

@OptimismBot OptimismBot merged commit 31967a7 into develop May 4, 2023
9 checks passed
@OptimismBot OptimismBot deleted the refcell/challenger/metrics branch May 4, 2023 19:23
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants