Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Add a bedrock warning #5627

Merged
merged 2 commits into from
May 5, 2023
Merged

feat(sdk): Add a bedrock warning #5627

merged 2 commits into from
May 5, 2023

Conversation

roninjin10
Copy link
Contributor

  • We saw 2 users of the sdk run into issues where they failed to set bedrock true and the error message wasn't very helpful
  • add a console.warn if bedrock is false
  • in future version of sdk we can make bedrock the default

@roninjin10 roninjin10 requested a review from a team as a code owner May 5, 2023 23:14
@roninjin10 roninjin10 requested a review from tremarkley May 5, 2023 23:14
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: aa854bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@eth-optimism/sdk Patch
@eth-optimism/chain-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot added the sdk label May 5, 2023
@netlify
Copy link

netlify bot commented May 5, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit aa854bd
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64558e7f15dd3400085ab4ed

@OptimismBot OptimismBot merged commit 352e0f5 into develop May 5, 2023
9 checks passed
@OptimismBot OptimismBot deleted the willc/warning branch May 5, 2023 23:32
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvmi7 jvmi7 jvmi7 approved these changes

@tremarkley tremarkley tremarkley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roninjin10 @jvmi7 @tremarkley @OptimismBot