You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ERC721 Bridge artifacts were copied into the bedrock package
in order to simplify our HH deployment scripts, without needing to read
artifacts from both the legacy contracts and contracts-periphery
packages.
However only the Proxy artifact is necessary. This artifact needs to be
deleted in order to deploy the updated ERC721 bridge implementation
during the setup phase of the mainnet deployments.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
IMO, we should make an archive directory for past deployments rather than deleting them. Doesn't have to be within the monorepo if you think that's messy, but preferably open source.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maurelian
force-pushed
the
jm/bedrock-deployments-cleanup
branch
from
Description
The ERC721 Bridge artifacts were copied into the bedrock package
in order to simplify our HH deployment scripts, without needing to read
artifacts from both the legacy contracts and contracts-periphery
packages.
However only the Proxy artifact is necessary. This artifact needs to be
deleted in order to deploy the updated ERC721 bridge implementation
during the setup phase of the mainnet deployments.