Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Update message-utils to mimic MigrateWithdrawalGasLimit #5658

Merged
merged 7 commits into from
May 9, 2023
Merged

feat(sdk): Update message-utils to mimic MigrateWithdrawalGasLimit #5658

merged 7 commits into from
May 9, 2023

Conversation

clabby
Copy link
Member

@clabby clabby commented May 9, 2023 •
edited
Loading

Overview

Updates the migratedWithdrawalGasLimit function in the SDK's message-utils.ts to mimic the new behavior of MigrateWithdrawalGasLimit in #5648.

Metadata

Closes CLI-3970

@clabby clabby requested a review from a team as a code owner May 9, 2023 09:17
@clabby clabby requested review from jakim929 and removed request for a team May 9, 2023 09:17
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9445344

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby
Copy link
Member Author

clabby commented May 9, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify mergify bot added the sdk label May 9, 2023
@mergify mergify bot requested a review from roninjin10 May 9, 2023 09:18
@clabby clabby force-pushed the clabby/sdk/migrated-withdrawal-gas branch from 0f2857a to d2951a3 Compare May 9, 2023 14:01
@tynes tynes merged commit d1d02ed into clabby/migration/min-gas-fix May 9, 2023
3 checks passed
@tynes tynes deleted the clabby/sdk/migrated-withdrawal-gas branch May 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes left review comments

@roninjin10 roninjin10 roninjin10 approved these changes

@jakim929 jakim929 Awaiting requested review from jakim929 jakim929 was automatically assigned from ethereum-optimism/ecosystem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clabby @tynes @roninjin10