Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RLP transactions #567

Closed
wants to merge 2 commits into from
Closed

feat: RLP transactions #567

wants to merge 2 commits into from

Conversation

karlfloersch
Copy link
Contributor

Co-authored-by: smartcontracts smartcontracts@doge.org

Description
Adds RLP transactions - #496

Co-authored-by: smartcontracts <smartcontracts@doge.org>
@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2021

⚠️ No Changeset found

Latest commit: 9318ad3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

},
}
} catch (err) {
// Do nothing, fall back to legacy decode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should increment a Counter here; cc @annieke

@snario
Copy link
Contributor

snario commented Apr 23, 2021

We probably don't need this backwards compatibility if we're going to be doing a re-genesis for this upgrade.

} catch (err) {
// Do nothing, fall back to legacy decode.
}

try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this decoding anymore because we don't have to be backwards compatible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is added to semver version 0.3.x

@karlfloersch
Copy link
Contributor Author

Closing this in favor of the rc branch here: https://github.com/ethereum-optimism/optimism/tree/v0.3.0-rc

@karlfloersch
Copy link
Contributor Author

#603

^ now tracking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants