-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Add extended peer store to store scores #5746
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5746 +/- ##
===========================================
+ Coverage 42.01% 42.07% +0.06%
===========================================
Files 448 451 +3
Lines 29147 29231 +84
Branches 877 877
===========================================
+ Hits 12246 12300 +54
- Misses 15956 15977 +21
- Partials 945 954 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c60b225
to
f453a6d
Compare
Supports storing gossip scores for peers.
f453a6d
to
c4f8e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to change it to bytes.Buffer
so we can merge this PR without delay and without buffer-pool risk, and can maybe land more of the work that you stacked on top. We can always optimize it in a follow-up PR.
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Starts building an extended peer store that supports persisting peer scores. Not currently hooked up and lacking pruning of old entries, but defines the interface and has a sensible implementation for persisting scores.
Tests
Unit tests for persistence functions.
Invariants
Metadata