integration-tests: deprecate #5926
Merged
+5
−6,021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy integration tests are no longer required. Delete the directory. This commit is helpful because it will reduce the amount of tests that need to run in CI. The legacy integration tests ran against the `ops` docker compose setup, which brought up the legacy system.
|
✅ Deploy Preview for opstack-docs canceled.
|
After deleting the `integration-tests` package
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5926 +/- ##
===========================================
- Coverage 42.95% 42.63% -0.33%
===========================================
Files 478 422 -56
Lines 30783 29886 -897
Branches 877 679 -198
===========================================
- Hits 13224 12742 -482
+ Misses 16533 16163 -370
+ Partials 1026 981 -45
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurermi
added a commit
to maurermi/optimism
that referenced
this pull request
May 10, 2024
Removes the seemingly obsolete rule to make integration tests from the root Makefile. Appears that integration tests were deprecated by PR ethereum-optimism#5926 and this rule no longer works.
maurermi
added a commit
to maurermi/optimism
that referenced
this pull request
May 10, 2024
Removes the seemingly obsolete rule to make integration tests from the root Makefile. Appears that integration tests were deprecated by PR ethereum-optimism#5926 and this rule no longer works.
maurermi
added a commit
to maurermi/optimism
that referenced
this pull request
May 10, 2024
Removes the seemingly obsolete rule to make integration tests from the root Makefile. Appears that integration tests were deprecated by PR ethereum-optimism#5926 and this rule no longer works.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
Removes the seemingly obsolete rule to make integration tests from the root Makefile. Appears that integration tests were deprecated by PR #5926 and this rule no longer works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The legacy integration tests are no longer required. Delete the directory. This commit is helpful because it will reduce the amount of tests that need to run in CI.
The legacy integration tests ran against the
opsdocker compose setup, which brought up the legacy system.