Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: delete l2geth-exporter #5932

Merged
merged 1 commit into from
Jun 9, 2023
Merged

cleanup: delete l2geth-exporter #5932

merged 1 commit into from
Jun 9, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 8, 2023

Description

Removes the l2geth-exporter package from the monorepo. This exposed metrics for the legacy system and is no longer necessary.

Removes the `l2geth-exporter` package from the monorepo.
This exposed metrics for the legacy system and is no longer
necessary.
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023

⚠️ No Changeset found

Latest commit: c50b02e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c50b02e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64821e032d311b0008fce89c

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #5932 (c50b02e) into develop (342e952) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5932      +/-   ##
===========================================
+ Coverage    43.03%   43.05%   +0.01%     
===========================================
  Files          477      477              
  Lines        30723    30723              
  Branches       877      877              
===========================================
+ Hits         13222    13227       +5     
  Misses       16472    16472              
+ Partials      1029     1024       -5     
Flag Coverage Δ
bedrock-go-tests 40.66% <ø> (+0.01%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 53.51% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 29.33% <ø> (ø)
sdk-tests 39.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think @protolambda wanted to copy the entire monorepo to a new repo to isolate + freeze pre-bedrock code. That should probably be done before this is merged.

@refcell
Copy link
Contributor

refcell commented Jun 8, 2023

@tynes tynes merged commit 40bdcc9 into develop Jun 9, 2023
92 checks passed
@tynes tynes deleted the cleanup/l2-geth-exporter branch June 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants