Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current syntax throws inaccurate error in op-proposer start script #6179

Merged

Conversation

cspannos
Copy link

Description
Absence of the '=' symbol in the script to start op-proposer throws a misleading error.

Tests
The existing script:

./bin/op-proposer \
    --poll-interval 12s \
    --rpc.port 8560 \
    --rollup-rpc http://localhost:8547 \
    --l2oo-address $L2OO_ADDR \
    --private-key $PROPOSER_KEY \
    --l1-eth-rpc $L1_RPC

produces this error:
t=2023-06-28T15:16:56+0000 lvl=crit msg="Application failed" message="flag l1-eth-rpc is required"

Updating the script with =:

./bin/op-proposer \
    --poll-interval=12s \
    --rpc.port=8560 \
    --rollup-rpc=http://localhost:8547 \
    --l2oo-address=$L2OO_ADDR \
    --private-key=$PROPOSER_KEY \
    --l1-eth-rpc=$L1_RPC

produces what I assume to be an accurate error:

INFO [06-28|15:22:40.444] Initializing L2 Output Submitter 
ERROR[06-28|15:22:40.444] Unable to create the L2 Output Submitter error="invalid address: " 
CRIT [06-28|15:22:40.444] Application failed                       message="invalid address: " 

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

⚠️ No Changeset found

Latest commit: 3b7e1bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit 3b7e1bf
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649c524a7e68ad00088c8a3a
😎 Deploy Preview https://deploy-preview-6179--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cspannos cspannos mentioned this pull request Jun 28, 2023
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix

@OptimismBot OptimismBot merged commit ed9d6a9 into ethereum-optimism:develop Jun 28, 2023
71 of 73 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 28, 2023
@cspannos cspannos deleted the proposer-docs-syntax-error branch June 30, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants