ci: move devnet test to make target

[jyellick]

When encountering devnet test failures in CI, they're challenging to resolve and reproduce locally because the commands are embedded into the CI configuration and not the Makefile.

This PR simply extracts the commands from the CI steps and embeds them into the devnet python module, allowing for the python script to be invoked with a new --test flag to execute those steps. It also adds a devnet-test make target to allow simple invocation of the script in test mode.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ee5ccb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	9b90e68
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/64bfe64a8409f200083f97a7

[tynes]

Generally in favor of the idea, not sure how I feel about the approach but could be open to it

[jyellick]

Generally in favor of the idea, not sure how I feel about the approach but could be open to it

I'm certainly happy to rework in some other way. As best as I could tell, the assorted build scripts are being migrated to python (vs. bash), so I tried to keep everything in the python, even though it's simply executing commands.

If there's a different preferred approach, please let me know. My goal here is primarily to allow developers to iterate while running tests without having to push it out and wait on CI.

[tynes]

Generally in favor of the idea, not sure how I feel about the approach but could be open to it

I'm certainly happy to rework in some other way. As best as I could tell, the assorted build scripts are being migrated to python (vs. bash), so I tried to keep everything in the python, even though it's simply executing commands.

If there's a different preferred approach, please let me know. My goal here is primarily to allow developers to iterate while running tests without having to push it out and wait on CI.

I am generally on board with this change after thinking about it more

[ajsutton]

Love this change - moving stuff from .circleci/config.yml into makefiles is a long term goal. Ideally we'd also move the devnet (with genesis contracts) tests as well, though that could be a separate PR as this is definitely an improvement.

If we do move the genesis tests, it would be great to remove the duplication as well so make devnet-test could just work for both genesis and deploy modes. I think the only difference is if --l1-contracts-json-path is specified or not so possibly it could switch based on whether that file exists or not.

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[jyellick]

I've updated the --test path of the python to add or omit the sdk address path depending on whether the file exists. Now, things should work both for make devnet-up and make devnet-up-deploy -- I've also updated the circle CI definition to use it in both paths.

[jyellick]

Is there anything preventing this from merging? Happy to make any desired changes if so.

[mergify]

Hey @jyellick! This PR has merge conflicts. Please fix them before continuing review.

[mergify]

Hey @jyellick! This PR has merge conflicts. Please fix them before continuing review.

[jyellick]

Rebased to try to keep this current (though no conflicts existed). Any updates from the maintainers? @tynes @ajsutton ?

[ajsutton]

LGTM, other than I think we want to keep the capturing of op-node logs. I'm not an infra reviewer though.

[ajsutton]

Oh turns out I am an infra reviewer. :) @jyellick Would you mind restoring the capturing of op-node logs and then I'll get this merged.

Thank you so much for your incredible patience - we've been really slow on a bunch of your PRs.

[ajsutton]

@jyellick The world is apparently out to get us today - the devnet build failed because of a network error downloading node. Can you kick it to rerun and then I think we should be good to go. It won't let me rerun because it look like its running in your circle ci org.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[jyellick]

Thanks @ajsutton, looks like the re-run fixed things, very happy to see this merge!

[mergify]

Hey @jyellick, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.