You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code adds the same signing key to all Ethereum clients (including the L2 nodes). I found this to be quite confusing when parsing the code, and, it's unnecessary for the L2s to have signing keys.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@jyellick Looks like CI is having a hard time. I don't really understand why yarn doesn't exist but there's been a bunch of changes and fixes around pnpm. Could you try rebasing this on top of latest develop and see if that helps please?
The current code adds the same signing key to all Ethereum clients
(including the L2 nodes). I found this to be quite confusing when
parsing the code, and, it's unnecessary for the L2s to have signing
keys.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jyellick
force-pushed
the
op-e2e-only-add-key-for-l1
branch
from
OptimismBot
merged commit 
The current code adds the same signing key to all Ethereum clients (including the L2 nodes). I found this to be quite confusing when parsing the code, and, it's unnecessary for the L2s to have signing keys.
cc @ajsutton