Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cannon-prestate as prereq to devnet-up #7049

Conversation

jyellick
Copy link
Contributor

The devnet-up ultimately requires the cannont-prestate target to have already executed, or the script errors out. Consequently, for someone checking out the repo if they simply do a:

make && make devnet-up

Things still fail. This change simply mirrors a similar check added to the e2e Makefile.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. :)

@ajsutton
Copy link
Contributor

I don't really know how contracts-bedrock-slither didn't get marked as passing - circleci shows it passed fine. @jyellick Can you pull in the latest changes from develop and see if the rebuild gets it sorted please?

Sorry for all the trouble CI seems to cause your PRs...

The devnet-up ultimately requires the cannont-prestate target to have
already executed, or the script errors out.  Consequently, for someone
checking out the repo if they simply do a:

```
make && make devnet-up
```

Things still fail.  This change simply mirrors a similar check added to
the e2e Makefile.
@jyellick jyellick force-pushed the build-add-cannon-prereq-to-devnet branch from 40e7318 to 26f2a01 Compare August 30, 2023 13:17
@jyellick
Copy link
Contributor Author

Yes, sorry for your cycles spent with the flaking CI as well.

Per your other suggestion to 'unfollow' the project in our Circle instance, unfortunately I don't think that will work, as we want to be able to run CI against changes that either aren't ready or aren't appropriate to upstream.

I am working to get the publish targets going by linking in a GCP instance, but I think there are other caching components of the CI that maybe should be enabled as well? Is there any infra-as-code type repo (or even simple docs) where it's established how to appropriately bootstrap the 3rd party components of the CI config?

@OptimismBot OptimismBot merged commit 528d0d2 into ethereum-optimism:develop Aug 30, 2023
62 of 70 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 30, 2023
@ajsutton
Copy link
Contributor

Per your other suggestion to 'unfollow' the project in our Circle instance, unfortunately I don't think that will work, as we want to be able to run CI against changes that either aren't ready or aren't appropriate to upstream.

Ah yeah, I was worried that would be the case. It's not a big deal - just means you need to manage rerunning if necessary rather than me.

I am working to get the publish targets going by linking in a GCP instance, but I think there are other caching components of the CI that maybe should be enabled as well? Is there any infra-as-code type repo (or even simple docs) where it's established how to appropriately bootstrap the 3rd party components of the CI config?

No I don't think we've written anything up there, probably worth raising an issue about it so the request is tracked. Most of the CI setup predates me so I'm not too familiar with it either to be honest.

@jyellick jyellick deleted the build-add-cannon-prereq-to-devnet branch September 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants