-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cannon-prestate as prereq to devnet-up #7049
Add cannon-prestate as prereq to devnet-up #7049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. :)
I don't really know how Sorry for all the trouble CI seems to cause your PRs... |
The devnet-up ultimately requires the cannont-prestate target to have already executed, or the script errors out. Consequently, for someone checking out the repo if they simply do a: ``` make && make devnet-up ``` Things still fail. This change simply mirrors a similar check added to the e2e Makefile.
40e7318
to
26f2a01
Compare
Yes, sorry for your cycles spent with the flaking CI as well. Per your other suggestion to 'unfollow' the project in our Circle instance, unfortunately I don't think that will work, as we want to be able to run CI against changes that either aren't ready or aren't appropriate to upstream. I am working to get the publish targets going by linking in a GCP instance, but I think there are other caching components of the CI that maybe should be enabled as well? Is there any infra-as-code type repo (or even simple docs) where it's established how to appropriately bootstrap the 3rd party components of the CI config? |
528d0d2
into
ethereum-optimism:develop
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Ah yeah, I was worried that would be the case. It's not a big deal - just means you need to manage rerunning if necessary rather than me.
No I don't think we've written anything up there, probably worth raising an issue about it so the request is tracked. Most of the CI setup predates me so I'm not too familiar with it either to be honest. |
The devnet-up ultimately requires the cannont-prestate target to have already executed, or the script errors out. Consequently, for someone checking out the repo if they simply do a:
Things still fail. This change simply mirrors a similar check added to the e2e Makefile.