op-service,op-node,op-program: default to new standard rpc-kind with eth_getBlockReceipts support #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eth_getBlockReceipts support
clabby
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth_getBlockReceiptshas been standard for a while now, and mostly adopted by all L1 clients. We can adopt it as a default.We leave the "basic" rpc kind unmodified, in case anyone needs it when
eth_getBlockReceiptsis broken on their L1 RPC.With
eth_getBlockReceiptsnodes should sync a little faster, since the method is more optimal (at least in L1 geth, where it only hydrates the receipts data once for the full block, rather than repeating the full work for the whole block per receipt call).Tests
Updated unit-tests to cover the new RPC kind.
Updated op-e2e and other tests to use this as RPC kind.