New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jq
to monorepo dependencies in CONTRIBUTING.md
#9018
Conversation
WalkthroughWalkthroughThe update to the CONTRIBUTING.md document specifies the addition of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…sm#9018) * docs: add jq to dependencies * docs: advise running `pnpm install` after `pnpm clean` and before `pnpm build`
Description
Edits to CONTRIBUTING.md:
jq
is an implicit dependency of the monorepo, without which the smart contract tests will fail to run:optimism/packages/contracts-bedrock/scripts/SemverLock.s.sol
Line 38 in ee8e6bb
pnpm clean
removesnode_modules
:optimism/package.json
Line 12 in 23dd85a
so
pnpm install
should be run before tryingpnpm build
.Tests
I tried to run
pnpm test
as per existing instructions withoutjq
installed and got lots of output such as:Installing
jq
fixed the problem.Additional context
These are just minor tweaks I discovered as a newcomer to the repo.
Metadata