add additional check before emitting log warning

[axelKingsley]

Avoids emitting a misleading log message if the buildingOnto is cleared out but we still have an async gossip payload to use.

[coderabbitai]

Walkthrough

Walkthrough

This update enhances the block-building process in the EngineController by introducing a new conditional check that ensures a reusable payload from an asynchronous gossiper is available before issuing a warning about potentially reorganizing the previous unsafe head. This improvement aims to bolster decision-making in block construction by leveraging additional network information.

Changes

File Path	Change Summary
op-node/rollup/derive/engine_controller.go	Added a conditional block to check for a reusable payload from an async gossiper before logging a warning about building a block that reorgs the previous unsafe head.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b4fb00) 29.00% compared to head (f45b91b) 0.65%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #9564       +/-   ##
===========================================
- Coverage    29.00%   0.65%   -28.36%     
===========================================
  Files          161      88       -73     
  Lines         7037    2304     -4733     
  Branches      1285     539      -746     
===========================================
- Hits          2041      15     -2026     
+ Misses        4890    2289     -2601     
+ Partials       106       0      -106     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.65% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

[protolambda]

LGTM, one nit on log wording/formatting