op-node/rollup/derive: also mark IsLast as true when closed && maxDataSize==readyBytes

[zhiqiangxu]

Otherwise there may be an empty frame of size 0 which is marked last.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve ensuring that the maximum data size is correctly set in two different contexts when it is greater than or equal to a given number, rather than just greater. Additionally, a new test has been added to verify the behavior of output frame generation when the last frame is not empty. These modifications improve accuracy and clarity in handling data sizes and enhance testing for output frame generation.

Changes

File(s)	Change Summary
op-node/rollup/derive/channel_out.go	Adjusted createEmptyFrame to set maxDataSize to uint64(readyBytes) when >= readyBytes.
op-e2e/actions/garbage_channel_out.go	In GarbageChannelOut, corrected max data size condition to >= and fixed a comment typo.
op-node/rollup/derive/.../channel_out_test.go	Added imports (io, math/rand) and a new test (TestOutputFrameNoEmptyLastFrame).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[ajsutton]

Could you add a test that demonstrates why this is need please?

[zhiqiangxu]

Could you add a test that demonstrates why this is need please?

Done.

[sebastianst]

LGTM. Nice catch.

I checked our local logs and we didn't hit that case on mainnet over the last 30 days, which would have been a channel with 2 frames in the op-node logs, but only one frame in op-batcher logs. Still worth fixing.

[ajsutton]

LGTM.