contracts-bedrock: fix deploy config for mainnet MCP upgrade #9865
Conversation
WalkthroughWalkthroughThe changes across various components streamline operations for the Ecotone upgrade, focusing on fee scalar adjustments, gas price oracle configurations, and superchain integration. These enhancements optimize encoding processes, ensure protocol compatibility, and improve system efficiency. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9865 +/- ##
============================================
- Coverage 42.40% 29.22% -13.18%
============================================
Files 73 31 -42
Lines 4830 2898 -1932
Branches 766 614 -152
============================================
- Hits 2048 847 -1201
+ Misses 2676 1976 -700
+ Partials 106 75 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I pushed additional commits so this needs another round of review before merge |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This should add some test coverage to L2 genesis generation |
protolambda
force-pushed
the
fix/mcp-config
branch
from
7107b6e
to
7ebf39a
Compare
|
This depends on #9935 now, since the op-geth update introduces breaking simulated-backend changes, which this needed to adapt to. |
The config param for the scalar was not updated in the deploy config when it was changed on chain. If we can enforce that the deploy config is always used as the source of truth for when doing on chain config changes, it can help to scale the team as other teams can use the same config file and know that the values in there represent the truth. This is a fundamental problem with the `initialize` pattern, we need to move away from it eventually. The deploy config is updated with the value that is used on mainnet and the parsing is updated to handle the new ecotone style config, which tightly packs the values into a single bytes32.
Ensures that the same consensus code is used to encode and decode the scalar in various places.
Make backwards compatible
Should match mainnet values
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
protolambda
force-pushed
the
fix/mcp-config
branch
from
3ffbeee
to
4de5c33
Compare
|
Rebased on develop, PR no longer depends on op-geth, the op-geth changes have landed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Description
The config param for the scalar was not updated in the
deploy config when it was changed on chain. If we can enforce
that the deploy config is always used as the source of truth
for when doing on chain config changes, it can help to scale
the team as other teams can use the same config file and know
that the values in there represent the truth. This is a fundamental
problem with the
initializepattern, we need to move away fromit eventually.
The deploy config is updated with the value that is used on
mainnet and the parsing is updated to handle the new ecotone
style config, which tightly packs the values into a single
bytes32. The overhead is set to 0 because it is no longer used post ecotone.