Skip to content

Commit

Permalink
Merge pull request #143 from ethereum-optimism/refcell/fix/chain-id
Browse files Browse the repository at this point in the history
fix: Inconsistent Chain ID Format
  • Loading branch information
refcell committed Apr 23, 2024
2 parents eefa56b + ede48fe commit a9b1cf9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion specs/interop/dependency_set.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ of executing messages.

The dependency set is configured on a per chain basis.

The chainid of the local chain MUST be considered as part of its own dependency set.
The chain id of the local chain MUST be considered as part of its own dependency set.

While the dependency set explicitly defines the set of chains that are depended on for incoming messages,
the full set of transitive dependencies must be known to allow for the progression of [safety](#safety).
Expand Down
2 changes: 1 addition & 1 deletion specs/interop/messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ struct Identifier {
| `blocknumber` | `uint256` | Block number in which the log was emitted |
| `logIndex` | `uint256` | The index of the log in the array of all logs emitted in the block |
| `timestamp` | `uint256` | The timestamp that the log was emitted. Used to enforce the timestamp invariant |
| `chainid` | `uint256` | The chainid of the chain that emitted the log |
| `chainid` | `uint256` | The chain id of the chain that emitted the log |

The [`Identifier`] includes the set of information to uniquely identify a log. When using an absolute
log index within a particular block, it makes ahead of time coordination more complex. Ideally there
Expand Down
2 changes: 1 addition & 1 deletion specs/interop/predeploys.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ as well as domain binding, ie the executing transaction can only be valid on a s

- Only callable by the `CrossL2Inbox`
- The `Identifier.origin` MUST be `address(L2ToL2CrossDomainMessenger)`
- The `_destination` chainid MUST be equal to the local chainid
- The `_destination` chain id MUST be equal to the local chain id
- The `CrossL2Inbox` cannot call itself

### Message Versioning
Expand Down
2 changes: 1 addition & 1 deletion specs/protocol/span-batches.md
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ The assumption makes upper inequality to hold. Therefore, we decided to manage `
- Transactions
- Deposit transactions can be derived from its L1 origin, identical with V0 batch.
- User transactions can be derived by following way:
- Recover `V` value of TX signature from `y_parity_bits` and L2 chainId, as described in optimization strategies.
- Recover `V` value of TX signature from `y_parity_bits` and L2 chain id, as described in optimization strategies.
- When parsing `tx_tos`, `contract_creation_bits` is used to determine if the TX has `to` value or not.

## Integration
Expand Down

0 comments on commit a9b1cf9

Please sign in to comment.