Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sepolia op-contracts/v1.4.0-rc.3 upgrade #200

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: Sepolia op-contracts/v1.4.0-rc.3 upgrade #200

merged 1 commit into from
May 28, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented May 15, 2024

Overview

Upgrades OP Sepolia to op-contracts/v1.4.0-rc.3

@clabby clabby self-assigned this May 15, 2024
@clabby clabby requested review from a team, maurelian, zchn and mds1 as code owners May 15, 2024 01:43
@clabby
feat: Sepolia op-contracts/v1.4.0-rc.3 upgrade
405fb27 
Upgrades OP Sepolia to `op-contracts/v1.4.0-rc.3`
@ajsutton
Copy link

Are the changes to the submodules deliberate? (Just checking because its so easy to accidentally change them)

@clabby
Copy link
Member Author

clabby commented May 15, 2024 •
edited

Are the changes to the submodules deliberate? (Just checking because its so easy to accidentally change them)

Yep - deliberate. Pulled in changes to support using the dispute contracts / FP deployment on OP Sepolia from the registry in the NestedSignFromJson script so that we can make post-checks.

The changes to script/DeployRehearsalContracts.s.sol are to make that script compatible with the new version of these dependencies.

clabby added a commit to ethereum-optimism/superchain-registry that referenced this pull request May 15, 2024
@clabby
feat: Update OP Sepolia addresses
7b1ada8 
## Overview

Updates the addresses on OP Sepolia in accordance w/ the upgrade in
ethereum-optimism/superchain-ops#200
@clabby clabby mentioned this pull request May 15, 2024
Merged
sebastianst pushed a commit to ethereum-optimism/superchain-registry that referenced this pull request May 16, 2024
@clabby @zchn @mds1
feat: Update OP Sepolia addresses (#235)
89d1dda 
* feat: Update OP Sepolia addresses

## Overview

Updates the addresses on OP Sepolia in accordance w/ the upgrade in
ethereum-optimism/superchain-ops#200

* add ASR + delayedweth impls

* bump semvers

* Update sealchain addresses to pass CI (#241)

* Update sealchain-2.json to pass CI

* pnpm codegen

* Update sealchain-1.json

* pnpm codegen

---------

Co-authored-by: Matt Solomon <matt@mattsolomon.dev>

---------

Co-authored-by: Kevin Z Chen <kevin.zchn@gmail.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
@maurelian maurelian mentioned this pull request May 21, 2024
Open
@maurelian
Copy link
Collaborator

Needs a new just simulate job added to CI.

@Inphi
Copy link
Contributor

Inphi commented May 23, 2024

Needs a new just simulate job added to CI.

@maurelian Note that unlike SC actions, this isn't a task that will always work across upgrades. Every time we upgrade FPs on sepolia, we'll need to update the CI task.
There aren't any CI tasks for other sepolia operations. Any particular reason why we need one for this op-contracts upgrade?

@maurelian maurelian added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 3673d09 May 28, 2024
11 checks passed
@maurelian maurelian deleted the cl/sepolia-fp-tag-sync branch May 28, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@zchn zchn Awaiting requested review from zchn zchn is a code owner

@mds1 mds1 Awaiting requested review from mds1 mds1 is a code owner

Assignees

@clabby clabby

@maurelian maurelian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clabby @ajsutton @maurelian @Inphi