Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestGenesisHash: move genesis generation code into validation module #78

Closed
geoknee opened this issue Feb 5, 2024 · 2 comments
Closed

TestGenesisHash: move genesis generation code into validation module #78

geoknee opened this issue Feb 5, 2024 · 2 comments
Assignees
@geoknee

Comments

@geoknee
Copy link
Contributor

geoknee commented Feb 5, 2024 

          As we discussed during our 1:1, we should ideally move the genesis generation loading code + hardcoded genesis hashes into the Registry.

Originally posted by @mslipper in #72 (review)
@geoknee geoknee mentioned this issue Feb 5, 2024
Merged
@geoknee
Copy link
Contributor Author

geoknee commented Feb 5, 2024

It won't be easy/clean to put the code in the superchain module because it may cause dependency conflicts or cycles.

@geoknee geoknee self-assigned this Feb 12, 2024
@geoknee geoknee mentioned this issue Feb 22, 2024
Closed
@geoknee
Copy link
Contributor Author

geoknee commented Feb 22, 2024

I made an attempt by reimplementing types from go-ethereum inside superchain. But that started to snowball very quickly.

@geoknee geoknee mentioned this issue Apr 18, 2024
Closed
@geoknee geoknee closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoknee geoknee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoknee