-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add TestGenesisHash (protocol parameter verification) #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #75 so you don't need my review afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed during our 1:1, we should ideally move the genesis generation loading code + hardcoded genesis hashes into the Registry.
Agreed. I'll queue that up for future work #78. |
Description
superchain
(e.g. genesis block nonce and many other fields)OptimismConfig
)Additional context
Inspired by Josh's
op-genesis
tool.I think there is an opportunity to move a lot or all of the code looped in from
op-geth
intosuperchain
. If we want to do that, will require some coordination between the two repos. Dependency relationships:validation
=>op-geth
(remove)validation
=>superchain
(keep)op-geth
=>superchain
(keep)Metadata