Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate OP Chain security reviews #31

Merged
merged 41 commits into from
Dec 7, 2023
Merged

Automate OP Chain security reviews #31

merged 41 commits into from
Dec 7, 2023

Conversation

zchn
Copy link
Contributor

@zchn zchn commented Nov 5, 2023

Previously, security reviews of OP Chains are done manually by downloading and running a script. This PR automates part of the process by performing the checks at the time when new chains are added to superchain-registry.

@zchn zchn changed the title Automate OP Chain security review [WIP] Automate OP Chain security review Nov 5, 2023
@zchn zchn changed the title [WIP] Automate OP Chain security review [WIP, DO NOT MERGE] Automate OP Chain security review Nov 12, 2023
@zchn zchn changed the title [WIP, DO NOT MERGE] Automate OP Chain security review Automate OP Chain security reviews Nov 17, 2023
@zchn zchn requested review from tynes and mds1 November 17, 2023 19:38
@zchn zchn marked this pull request as ready for review November 17, 2023 19:39
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
script/CheckSecurityConfigs.s.sol Outdated Show resolved Hide resolved
script/CheckSecurityConfigs.s.sol Outdated Show resolved Hide resolved
script/CheckSecurityConfigs.s.sol Outdated Show resolved Hide resolved
script/CheckSecurityConfigs.s.sol Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
foundry.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
script/CheckSecurityConfigs.s.sol Outdated Show resolved Hide resolved
foundry.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since all my comments were addressed, pending any remaining decisions around repo ownership/codeowners

@zchn zchn removed the request for review from tynes December 7, 2023 19:54
@zchn zchn merged commit fb3433d into main Dec 7, 2023
5 checks passed
@zchn zchn deleted the k1014/sec-215-pgn-review branch December 7, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants