Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security bug: nothing-at-stake for tokens - no ERC-721 value anymore attack #3619

Closed
vporton opened this issue Jun 18, 2021 · 3 comments
Closed
Labels

Comments

@vporton
Copy link
Contributor

vporton commented Jun 18, 2021

We have an attack on PoS Ethereum: attack any token(s) in the same way as ETH could be attacked by the same way as the well-known nothing-at-stake attack.

The first method of NAS protection from https://eth.wiki/en/concepts/proof-of-stake-faqs does not work for this, because the value of a token may be unknown or even highly different in two forks.

The second method should work, but...

It does not work for NFTs such as ERC-721, because the value of an NFT can't be split into two parts (it is 1 wei).

Stupid NFT fans, get rid of NFTs!

@vporton
Copy link
Contributor Author

vporton commented Jun 18, 2021

The protection for non-NFTs (ERC-20 and ERC-1155) can be done this way only by integrating fining token holders into Ethereum core.

That's quite possible to be done if we restrict ourselves only to ERC-20 and ERC-1155 tokens (ERC-20 was a bad idea, it would be better to have only ERC-1155; adding new token types not belonging to these two ERCs makes no sense because ERC-1155 has all features a token could have; people still can create new standards of tokens, but these new (useless) kinds would be liable to the above described attack).

@github-actions
Copy link

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Oct 24, 2021
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant