Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign the EIP based on the PR number #988

Closed
jamesray1 opened this issue Apr 8, 2018 · 5 comments
Closed

Assign the EIP based on the PR number #988

jamesray1 opened this issue Apr 8, 2018 · 5 comments

Comments

@jamesray1
Copy link
Contributor

At the moment when you create a PR, you make it compatible to merge and wait or request for an EIP number to be assigned. But for the discussions-to field in the header, if you create a GItter issue, you have to edit it to update the EIP title with the number and the link on the EIPs website. I suggest adding the EIP number based on the PR number. But I guess it's not too much extra effort to change the EIP title after merging, while the link on the Gitter topic would need to updated from the PR to the EIP webpage anyway.

@5chdn
Copy link
Contributor

5chdn commented Apr 9, 2018

This is already the case even though it's not formalized yet. However, in some cases the EIP number is taken from the issue number that discussed the topic before creating an actual proposal (e.g., #156, #649).

If you want to formalize that, we could just add it to EIP-1, however, I am not entirely sure if we want to stick to Github forever with this process. Just my thoughts.

@jamesray1
Copy link
Contributor Author

jamesray1 commented Apr 9, 2018

Yeah, I was aware that sometimes the issue number was used instead, which is OK. At any rate these instructions about what to do with the discussions-to field would help with making an EIP.

@5chdn
Copy link
Contributor

5chdn commented Apr 9, 2018

Discussions-to is used by http://eips.ethereum.org/ to readers that want to discuss a proposal. Could be a link to a forum or the GitHub issue or Reddit, or anything really that allows to maintain a persistent record of the discussion.

@jamesray1
Copy link
Contributor Author

OK sure, yeah I understand that, the guidelines could be generalized.

@axic
Copy link
Member

axic commented May 21, 2019

The text

the EIP editor will assign the EIP a number (generally the issue or PR number related to the EIP)

has been in EIP-1 at least since Feb 2017.

What exactly needs to be changed/improved here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants