New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-2384 - Difficulty Bomb Delay #2384

Merged

axic merged 7 commits into ethereum:master from econoar:master

Nov 22, 2019

Contributor

econoar commented Nov 20, 2019 •

edited

Initial submission of EIP-2019 which would delay the difficulty bomb.

econoar added 2 commits

November 20, 2019 10:44


          Create eip-2019.md

10a92d9


          update

8046f26

axic reviewed

View reviewed changes

EIPS/eip-2019.md Outdated Show resolved Hide resolved

evertonfraga mentioned this pull request

[EIP 2384]: Implement difficulty bomb delay ethereumjs/ethereumjs-block#79

Closed

4 tasks


          update EIP number to 2384

econoar changed the title ~~EIP-2019 - Difficulty Bomb Delay~~ EIP-2384 - Difficulty Bomb Delay

axic reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved

axic reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved

axic reviewed

View reviewed changes

EIPS/eip-2384.md Show resolved Hide resolved

axic reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved


          update eip-2384

a97193d

Added better title, updated motivation with exact block numbers and date, fixed links and added a discussion link.

holiman reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved

This was referenced Nov 21, 2019

consensus/ethash, params: implement eip-2384: bump difficulty bomb ethereum/go-ethereum#20347

Merged

add difficulty test for EIP-2384 ethereum/tests#662

Merged


          update eip-2384.md

f51376a

clarify language around block counts away from different forks

axic reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved

shemnon mentioned this pull request

EIP2384 - Ice Age Adustment around Istanbul hyperledger/besu#211

Merged

axic reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved


          update eip-2384.md

fbe05c8

spelling mistake and eth-mags discussion link

sassal reviewed

View reviewed changes

EIPS/eip-2384.md Outdated Show resolved Hide resolved


          update eip-2384.md

02505ba

grammar

axic approved these changes

View reviewed changes

axic merged commit 1a627a7 into ethereum:master

tjayrush commented Dec 2, 2019 •

edited

Why not choose a number that sets the fake_block number to a known quantity like 50,000 or 100,000? If we did that, the period would get set back to 0 or 1 and the amount of time between bomb diffusions would be maximized. Choosing 9,000,000 setback is arbitrary and depends on fork block which adds a bit of uncertainty that seems unnecessary. (It will set the period back to 1 most likely, though.)

The arbitrary choice of 5,000,000 for the previous bomb diffusion is, I think, why the bomb is appearing so early this time.

Member

axic commented Dec 2, 2019

@tjayrush can you please leave this comment on the discussion URL?

cyber-hokie mentioned this pull request

Update EIP-2384 to Final Status #2447

Merged

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request


          EIP-2384 - Difficulty Bomb Delay (ethereum#2384)

7baf04c

Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request


          EIP-2384 - Difficulty Bomb Delay (ethereum#2384)

7bd8644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment