Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Advertisement Tracking Interface #165

Merged
merged 11 commits into from Apr 24, 2024

Conversation

wartstone
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Dec 15, 2023

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add ERC: Inter dapp tracking standard proposal Add ERC: Inter dapp tracking standard inferface Dec 15, 2023
@github-actions github-actions bot added the w-ci label Dec 15, 2023
ERCS/erc-xxxx.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci label Dec 18, 2023
@eip-review-bot eip-review-bot changed the title Add ERC: Inter dapp tracking standard inferface Add ERC: Inter dapp tracking inferface Dec 18, 2023
Copy link

The commit 2baeb4e (as a parent of 21cb2e2) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added w-ci and removed w-ci labels Dec 26, 2023
@wartstone wartstone force-pushed the master branch 2 times, most recently from ac42ab3 to f4a122c Compare January 2, 2024 09:28
@wartstone
Copy link
Contributor Author

File ERCS/erc-7580.md

Requires 1 more reviewers from @axic, @g11tech, @Pandapip1, @SamWilsn, @xinbenlv

any update on this? apprecate it~

@wartstone
Copy link
Contributor Author

File ERCS/erc-7580.md

Requires 1 more reviewers from @axic, @g11tech, @Pandapip1, @SamWilsn, @xinbenlv

any update on this? apprecate it~

Hi all, @abcoathup @axic @g11tech @Pandapip1 @SamWilsn @xinbenlv , we need review here, thanks~

@wartstone
Copy link
Contributor Author

Confused here? what would be the next step? thx:)

@wartstone wartstone force-pushed the master branch 2 times, most recently from 8ec77d0 to 1a2844b Compare January 22, 2024 09:38
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@wartstone
Copy link
Contributor Author

We may need a reviewer here. that would be awesome

@eip-review-bot eip-review-bot changed the title Add ERC: Inter dapp tracking inferface Add ERC: Advertisement Tracking Interface Feb 21, 2024
@chenly
Copy link
Contributor

chenly commented Feb 24, 2024

Could you please explain the purpose of the parameters contract_address and function_hash within the function? It seems like the core of this proposal is to pass messages between two contracts, is that correct?

ERCS/erc-7580.md Show resolved Hide resolved
ERCS/erc-7580.md Outdated Show resolved Hide resolved
@wartstone
Copy link
Contributor Author

wartstone commented Mar 8, 2024

Could you please explain the purpose of the parameters contract_address and function_hash within the function? It seems like the core of this proposal is to pass messages between two contracts, is that correct?

The core of proposal would like to offer good tracking mechanism for advertisement purpose, the contract_address and function_hash serve to identify the specific advertisement action. We're updating a new version which would also include function parameters, and these all would precisely describe the advertiser demands.

Tracking mechanism would act like ads sdk in web2/mobile. Project call onTrackStart and onTrackEnd to deliver the user ads interaction.

Copy link

github-actions bot commented Apr 5, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

ERCS/erc-7580.md Outdated Show resolved Hide resolved
ERCS/erc-7580.md Outdated Show resolved Hide resolved
ERCS/erc-7580.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for a draft, but I'd still like to see some more detail on how the off-chain components are supposed to work. Your rationale is also a bit light.

@eip-review-bot eip-review-bot enabled auto-merge (squash) April 24, 2024 18:20
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit d1b8d24 into ethereum:master Apr 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants