Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: ERC-1155 Multi-Asset extension #220

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

haruu8
Copy link

@haruu8 haruu8 commented Jan 25, 2024

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@haruu8 haruu8 changed the title Add EIP: Multi-Context Dependent Multi-Asset Tokens, EIP-1155 Extension Add ERC: Multi-Context Dependent Multi-Asset Tokens, EIP-1155 Extension Jan 25, 2024
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 25, 2024

✅ All reviewers have approved.

@@ -0,0 +1,158 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
---
eip: 7603

Assigning next sequential EIP/ERC/RIP number.
Numbering changed to sequential from 7500 and is no longer the PR number.

Please also update the filename.

@@ -0,0 +1,158 @@
---
title: Context-Dependent Multi-Asset Tokens, EIP-1155 Extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Context-Dependent Multi-Asset Tokens, EIP-1155 Extension
title: Context-Dependent Multi-Asset Tokens, ERC-1155 extension

@eip-review-bot eip-review-bot changed the title Add ERC: Multi-Context Dependent Multi-Asset Tokens, EIP-1155 Extension Add ERC: ERC-1155 Multi-Asset extension Jan 27, 2024
@github-actions github-actions bot added w-ci and removed w-ci labels Jan 27, 2024
Copy link

The commit abc081a (as a parent of b8e2bf3) contains errors.
Please inspect the Run Summary for details.

@haruu8
Copy link
Author

haruu8 commented Jan 27, 2024

@abcoathup
Thank you for pointing out some mistakes; I modified the code based on your provided information. I'll be glad if you recheck the PR.

@haruu8 haruu8 requested a review from abcoathup January 27, 2024 04:22
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these at some point, but this looks good for a Draft.


The Multi-Asset Token standard, compatible with [ERC-1155](./erc-1155.md), facilitates the development of a new fundamental component: the context-dependent data output for each collection.

The context-dependent data output means that the asset is displayed in an appropriate format based on how the token is accessed. I.e., if the token is being opened in an e-book reader, the PDF asset is displayed; if the token is opened in the marketplace, the PNG or the SVG asset is displayed; if the token is accessed from within a game, the 3D model asset is accessed, and if the token is accessed by the (Internet of Things) IoT hub, the asset providing the necessary addressing and specification information is accessed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The context-dependent data output means that the asset is displayed in an appropriate format based on how the token is accessed. I.e., if the token is being opened in an e-book reader, the PDF asset is displayed; if the token is opened in the marketplace, the PNG or the SVG asset is displayed; if the token is accessed from within a game, the 3D model asset is accessed, and if the token is accessed by the (Internet of Things) IoT hub, the asset providing the necessary addressing and specification information is accessed.
The context-dependent data output means that the asset is displayed in an appropriate format based on how the token is accessed. I.e., if the token is being opened in an e-book reader, the PDF asset is displayed; if the token is opened in the marketplace, the PNG or the SVG asset is displayed; if the token is accessed from within a game, the 3D model asset is accessed, and if the token is accessed by an Internet of Things (IoT) hub, the asset providing the necessary addressing and specification information is accessed.


pragma solidity ^0.8.23;

interface IERC7603 /* is ERC165 */ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally explicitly state the ERC-165 identifier somewhere in the document to make sure things line up correctly.


## Rationale

TBD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TBD
TBD
<!-- TODO -->

If you use HTML-style comments, the linter will make sure you replace them before your document goes into Review.


## Security Considerations

Needs discussion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Needs discussion.
Needs discussion. <!-- TODO -->

@eip-review-bot eip-review-bot enabled auto-merge (squash) May 15, 2024 20:29
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-stale label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants