Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: ERC-1155 Permit Approvals #223
Add ERC: ERC-1155 Permit Approvals #223
Changes from 22 commits
c3cf465
cf8a684
0be2807
8e9ea3d
0b3f1de
e895a17
f625dc1
ec21171
7867f02
da9b6ac
bbcf4c8
79e8aa8
d474c66
3f97305
cffe078
cd8be14
2f3736a
985e7d8
45affd0
ad6d7d4
8c00f13
240f09e
704665c
0133674
e0230cc
aa03fad
17a130e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally not a fan of the inclusion of an arbitrary
bytes data
field.I feel it's unnecessary and out of scope of the requirements of a permit function - 99.99% of the time it will be a waste of gas (about 350 units).
It's also not present in any other permit standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to removing this, but I would also like to hear some more feedback on possible usecases, or if it is mostly useless, before making a final decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emiliolanzalaco I think I have removed all the references to the additional
bytes data
paramater. Can you give the doc a look over to make sure I didn't miss any?