Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Atomic Push-based Data Feed Among Contracts #235

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

lanyinzly
Copy link
Contributor

Add ERC: Smart Contract Data Push Mechanism

An Atomic Mechanism to Allow Publisher Contract Push Data to Subscriber Contracts

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 3, 2024

File ERCS/erc-7615.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

ERCS/ERC-xxxx Outdated Show resolved Hide resolved
@lanyinzly lanyinzly changed the title Add ERC: Smart Contract Data Push Mechanism Add ERC: Atomic Push-based Data Feed Among Contracts Feb 7, 2024
@github-actions github-actions bot removed the w-ci label Feb 7, 2024
@github-actions github-actions bot added the w-ci label Feb 7, 2024
ERCS/ERC-xxxx Outdated Show resolved Hide resolved
Copy link

The commit c620a87 (as a parent of 28946e3) contains errors.
Please inspect the Run Summary for details.

@eip-review-bot eip-review-bot enabled auto-merge (squash) February 18, 2024 16:16
eip-review-bot
eip-review-bot previously approved these changes Feb 18, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 18, 2024 16:17

Head branch was pushed to by a user without write access

@github-actions github-actions bot removed the w-ci label Feb 18, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) February 18, 2024 16:18
eip-review-bot
eip-review-bot previously approved these changes Feb 18, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled February 18, 2024 16:21

Head branch was pushed to by a user without write access

@lanyinzly
Copy link
Contributor Author

It says "All Reviewers Have Approved; Performing Automatic Merge..." on Feb 18, but it still requires review and cannot be merged. Any feedback or could you help to merge? @axic , @g11tech , @SamWilsn , @xinbenlv

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@SamWilsn SamWilsn closed this May 21, 2024
@SamWilsn SamWilsn reopened this May 21, 2024
@github-actions github-actions bot removed the w-stale label May 22, 2024
Comment on lines +65 to +87
```
+---------+ +-----------+ +-------------+
| Client | | Publisher | | Subscriber |
+---------+ +-----------+ +-------------+
| | |
| Call somefunc(...) | |
|------------------------->| |
| | |
| | Query Subscriber |
| |----------------- |
| | | |
| |<---------------- |
| | |
| | Call exec(bytes4 selector, bytes calldata data) |
| |------------------------------------------------------->|
| | |
| | Result |
| |<-------------------------------------------------------|
| | |
| Result | |
|<-------------------------| |
| | |
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great ascii art, but generally we prefer SVGs in the assets/ directory.

## Reference Implementation

```solidity
// SPDX-License-Identifier: MIT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in the document itself must be licensed under CC0-1.0. I allow MIT licensed code in the assets/ directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants