Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: ERC-721 Ownership Shares Extension #266

Merged
merged 42 commits into from
Apr 16, 2024
Merged

Add ERC: ERC-721 Ownership Shares Extension #266

merged 42 commits into from
Apr 16, 2024

Conversation

chenly
Copy link
Contributor

@chenly chenly commented Feb 17, 2024

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 17, 2024 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add ERC：Data Access Control Website: Add ERC：Data Access Control Feb 17, 2024
@github-actions github-actions bot added the w-ci label Feb 17, 2024
@github-actions github-actions bot removed the w-ci label Feb 17, 2024
@chenly chenly changed the title Website: Add ERC：Data Access Control Add ERC：Data Access Control Feb 17, 2024
@eip-review-bot eip-review-bot changed the title Add ERC：Data Access Control Website: Add ERC：Data Access Control Feb 18, 2024
@chenly chenly changed the title Website: Add ERC：Data Access Control Add ERC：Data Access Control Feb 18, 2024
abcoathup
abcoathup reviewed Feb 18, 2024
View reviewed changes
ERCS/erc-7626.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot changed the title Add ERC：Data Access Control Website: Add ERC：Data Access Control Feb 18, 2024
abcoathup
abcoathup reviewed Feb 19, 2024
View reviewed changes
ERCS/erc-7626.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Feb 19, 2024
View reviewed changes
ERCS/erc-7626.md Outdated Show resolved Hide resolved
liaoyuan and others added 5 commits February 19, 2024 11:22
change title
c407c14
@chenly @abcoathup
Update ERCS/erc-7626.md
20c7af4 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@chenly @abcoathup
Update ERCS/erc-7626.md
9c811ea 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
rename eip #
22de7f7
rename
9af4272
@chenly chenly changed the title Website: Add ERC：Data Access Control Add ERC：Off-chain Data Access Control Feb 19, 2024
@github-actions github-actions bot added the w-ci label Feb 24, 2024
@github-actions github-actions bot removed the w-ci label Feb 24, 2024
SamWilsn
SamWilsn reviewed Mar 5, 2024
View reviewed changes
ERCS/erc-7628.md Outdated Show resolved Hide resolved
ERCS/erc-7628.md Outdated Show resolved Hide resolved
ERCS/erc-7628.md Outdated Show resolved Hide resolved
ERCS/erc-7628.md Outdated Show resolved Hide resolved
ERCS/erc-7628.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot changed the title Add ERC: ERC-721 Balance Extension Add ERC: ERC-721 Ownership Shares Extension Mar 6, 2024
@chenly chenly requested a review from SamWilsn March 6, 2024 18:16
@chenly chenly mentioned this pull request Mar 17, 2024
Closed
13 tasks
@poojaranjan poojaranjan mentioned this pull request Mar 19, 2024
Closed
18 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 3, 2024
Closed
27 tasks
@eip-review-bot eip-review-bot enabled auto-merge (squash) April 16, 2024 14:15
eip-review-bot
eip-review-bot approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit c2bca09 into ethereum:master Apr 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@Jean68172 Jean68172 Jean68172 approved these changes

@eip-review-bot eip-review-bot eip-review-bot approved these changes

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chenly @eip-review-bot @abcoathup @SamWilsn @Jean68172 @bizliaoyuan