Update ERC-5521: Move to Last Call #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
|
The commit 3525d94 (as a parent of 7a5255f) contains errors. |
13 tasks
18 tasks
SamWilsn
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Looks great overall! My only complaint is that your rationale section doesn't really explain choices you made within the proposal itself. Instead, you're justifying the EIP as a whole.
The rationale section should explain why, for example, UpdateNode indexes some of its arguments and not all of them.
My analogy for the difference between Motivation and Rationale is:
Motivation: Why do we need to build a shed?
Rationale: Why did I paint the shed red?
27 tasks
Response to comments from reviewers
Thanks for that @SamWilsn We've fixed this and more grammar errors and typos. |
19 tasks
SamWilsn
approved these changes
May 24, 2024
eip-review-bot
approved these changes
May 24, 2024
eip-review-bot
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on https://ethereum-magicians.org/t/eip-5521-erc-721-referable-nft/10310.
Updated on 17 Apr: The method
createdTimestampOfhas been added to the interface to specifically emphasize the necessity of setting thecreatedTimestampfor each rNFT. This addition is not about implementation details but is a part of the specification.Updated on 23 Apr: Fixed the grammar errors and typos.