Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-1363: Update ERC-1363 to follow EIP-1 recommendation #31

Conversation

vittominacori
Copy link
Contributor

This PR wants to only update EIP content in order to follow the most updated recommendation from EIP-1.

  • Some texts have been updated to better explain the ERC-1363 behavior, after years of discussion. No changes in behavior.
  • Some texts have been moved from abstract or motivation to the dedicated rationale section.
  • References to EIPs have been moved to the EIP-N format.
  • Code specification have been indented and commented.
  • The creation date have been updated with the date of the first issue opening and the first commit into the reference implementation (erroneously it was the date of PR instead).

Former ethereum/EIPs#7877

@vittominacori vittominacori changed the title Update EIP1363 to follow EIP-1 recommendation Update ERC-1363 to follow EIP-1 recommendation Oct 26, 2023
@github-actions github-actions bot added the w-ci label Oct 26, 2023
@vittominacori
Copy link
Contributor Author

vittominacori commented Oct 27, 2023

@SamWilsn moved the PR here.

It still continue fail ci but not for the code added by me.

Is there something I can do to solve that issue?

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 28, 2023

File ERCS/erc-1363.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eip-review-bot eip-review-bot changed the title Update ERC-1363 to follow EIP-1 recommendation Update ERC-1363: Update ERC-1363 to follow EIP-1 recommendation Oct 28, 2023
@github-actions github-actions bot removed the w-ci label Oct 28, 2023
@github-actions
Copy link

The commit b106695 (as a parent of 5f2d25e) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Oct 28, 2023
@vittominacori
Copy link
Contributor Author

Still cannot understand how to fix that ci issue.
I've pointed internal links to ./erc-x.md but is still says that required files do not exist.
https://github.com/ethereum/ERCs/actions/runs/6677043725/job/18146675819?pr=31

@SamWilsn
Copy link
Collaborator

@vittominacori the CI is still a bit broken from splitting the repositories. Not your fault. We can override the bots.

@SamWilsn
Copy link
Collaborator

Final proposals cannot be edited, apart from errata (like the created date) or adding clarifications that don't change the behaviour of the standard. This pull request is changing a lot. Too much really.

If you'd like to update to the latest formatting guidelines, do that in a separate pull request from any content changes. If you do want to make any content changes (errata or clarifications), keep them as small and simple as possible.

For my own sanity, I'm going to be closing pull requests aggressively on this repository. Please don't take that to mean we don't value your contribution. Always feel free to re-open a pull request if you think it has been closed prematurely. Thanks!

@SamWilsn SamWilsn closed this Oct 30, 2023
@vittominacori
Copy link
Contributor Author

Ok thanks. I know it could seem that the whole EIP was changed but the most are changes required by validator.

I will change one section at a time and PR also if it won't pass the CI (to pass I must edit all the sections again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants