Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-20: Fix broken link on erc-20.md #324

Closed
wants to merge 1 commit into from

Conversation

shahbaz17
Copy link

Fix broken link under Implementation for OpenZeppelin and ConsenSys implementation

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Fix broken link under Implementation for OpenZeppelin and ConsenSys implementation
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 15, 2024

File ERCS/erc-20.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eip-review-bot eip-review-bot changed the title Fix broken link on erc-20.md Update ERC-20: Fix broken link on erc-20.md Mar 15, 2024
Copy link

The commit d21d07a (as a parent of 7883f61) contains errors.
Please inspect the Run Summary for details.

@SamWilsn
Copy link
Collaborator

The current links appear to be working: https://eips.ethereum.org/EIPS/eip-20#implementation

@SamWilsn SamWilsn closed this Mar 27, 2024
@shahbaz17
Copy link
Author

Screenshot 2024-03-27 at 7 43 50 PM

These two links are still not working. When opening through the Markdown file. Can you confirm once?

It's here as I see: https://github.com/ethereum/ERCs/blob/master/assets/erc-20/Consensys-EIP20.sol and https://github.com/ethereum/ERCs/blob/master/assets/erc-20/OpenZeppelin-ERC20.sol

@SamWilsn
Copy link
Collaborator

SamWilsn commented Apr 8, 2024

None of the asset links work in the GitHub markdown preview, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants