Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Release tokens on predefined periods #347

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

erc4377
Copy link

@erc4377 erc4377 commented Mar 26, 2024

Tokens can be linearly released based on the predefined periods,enable lock token balances and gradually release tokens.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 26, 2024

File ERCS/erc-7660.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Release [ERC-20] tokens on predefined periods Add ERC: Release [ERC-20] tokens on predefined periods Mar 26, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Release [ERC-20] tokens on predefined periods Add ERC: Release tokens on predefined periods Mar 26, 2024
ERCS/erc-7660.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci label Apr 27, 2024
@github-actions github-actions bot removed the w-ci label Apr 27, 2024
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biggest blocker for this proposal is that you haven't convinced me that this needs to be a standard. Please convince the reader, in the document, that you need an ERC for this idea (instead of simply making your token vest without an ERC for that feature.)

ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
ERCS/erc-7660.md Outdated Show resolved Hide resolved
@SamWilsn
Copy link
Collaborator

Not sure if you're still working on this or if it's ready for re-review, but you will need to address the comments in the Rationale section before this can be merged.

Copy link

The commit 85d57e6 (as a parent of 8338f56) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jun 16, 2024
@github-actions github-actions bot removed the w-ci label Jun 16, 2024
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still don't really explain in the document why this needs to be a standard.

If I want to use this release mechanism, I can add it to my contract, and it'll just work for everyone. What parts of this standard require modifications to, for example, wallets? Block explorers?


## Motivation

Rely on this new standard to establish a Token category with a consensus period by default (passive), rather than the motivation and means of linear release (subjective).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define the terms you're using here? Specifically "consensus period", "passive", "linear release" and "subjective". I'm not an expert on tokens, so I probably represent the average reader of ERCs pretty well, and I have no idea what you're talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants