-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Release tokens on predefined periods #347
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biggest blocker for this proposal is that you haven't convinced me that this needs to be a standard. Please convince the reader, in the document, that you need an ERC for this idea (instead of simply making your token vest without an ERC for that feature.)
Not sure if you're still working on this or if it's ready for re-review, but you will need to address the comments in the Rationale section before this can be merged. |
The commit 85d57e6 (as a parent of 8338f56) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still don't really explain in the document why this needs to be a standard.
If I want to use this release mechanism, I can add it to my contract, and it'll just work for everyone. What parts of this standard require modifications to, for example, wallets? Block explorers?
|
||
## Motivation | ||
|
||
Rely on this new standard to establish a Token category with a consensus period by default (passive), rather than the motivation and means of linear release (subjective). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you define the terms you're using here? Specifically "consensus period", "passive", "linear release" and "subjective". I'm not an expert on tokens, so I probably represent the average reader of ERCs pretty well, and I have no idea what you're talking about.
Tokens can be linearly released based on the predefined periods,enable lock token balances and gradually release tokens.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: