Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: Upgradeable Clone for Scalable Contracts #39

Merged
merged 47 commits into from Apr 8, 2024
Merged

Add ERC: Upgradeable Clone for Scalable Contracts #39

merged 47 commits into from Apr 8, 2024

Conversation

kaihiroi
Copy link
Contributor

Migrate from EIPs repository

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 28, 2023 •
edited

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add ERC: Upgradeable Clone Website: Upgradeable Clone Oct 28, 2023
@github-actions github-actions bot added w-ci and removed w-ci labels Oct 28, 2023
@eip-review-bot eip-review-bot changed the title Website: Upgradeable Clone Add ERC: Upgradeable Clone Oct 30, 2023
@github-actions github-actions bot added w-ci and removed w-ci labels Oct 30, 2023
@github-actions github-actions bot removed the w-stale label Mar 22, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Upgradeable Clone with Function-oriented Dictionary Beacon and Factory Pattern Add ERC: Upgradeable Clone for Scalable Contracts Mar 27, 2024
@github-actions github-actions bot removed the w-ci label Mar 27, 2024
SamWilsn
SamWilsn reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Just a few more things before merging as Draft.

ERCS/erc-7546.md Outdated Show resolved Hide resolved
ERCS/erc-7546.md Outdated Show resolved Hide resolved
ERCS/erc-7546.md Outdated Show resolved Hide resolved
ERCS/erc-7546.md Outdated Show resolved Hide resolved
ERCS/erc-7546.md Outdated Show resolved Hide resolved
assets/erc-7546/images/comparison-with-beacon.png Outdated Show resolved Hide resolved
kaihiroi and others added 6 commits March 28, 2024 10:05
@kaihiroi @SamWilsn
Update ERCS/erc-7546.md
6a428e7 
Revision of English expression

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@kaihiroi @SamWilsn
Update ERCS/erc-7546.md
af03561 
Clarify the expression about event

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@kaihiroi
remove implementation detail from abstract section
0f3bd22
@kaihiroi
backticks to italic
c26a7eb
@kaihiroi
replace PNG with SVG
35679e1
@SamWilsn
Update ERCS/erc-7546.md
47c435f
SamWilsn
SamWilsn previously approved these changes Mar 29, 2024
View reviewed changes
@eip-review-bot eip-review-bot enabled auto-merge (squash) March 29, 2024 15:19
eip-review-bot
eip-review-bot previously approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled March 29, 2024 17:31

Head branch was pushed to by a user without write access

@kaihiroi kaihiroi dismissed stale reviews from eip-review-bot and SamWilsn via 060aa57 March 29, 2024 17:31
@github-actions GitHub Actions
Copy link

The commit 060aa57 (as a parent of 5073766) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Mar 29, 2024
@github-actions github-actions bot removed the w-ci label Mar 29, 2024
@kaihiroi
Copy link
Contributor Author

@SamWilsn
My apologies for the inconvenience, and thank you for your patience and support.
I have updated the reference implementation based on the feedback received and have changed the license to CC0.
Could you please take a moment to review the updated implementation and the license change?

@eip-review-bot eip-review-bot enabled auto-merge (squash) April 8, 2024 16:18
eip-review-bot
eip-review-bot approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit cabb04f into ethereum:master Apr 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@abcoathup abcoathup Awaiting requested review from abcoathup

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kaihiroi @eip-review-bot @xinbenlv @abcoathup @SamWilsn @Pandapip1 @shogochiai