Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Dynamic Compliant Interop Security Token #67

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

rajatwasan
Copy link

Dynamic Compliant Interop Security Token(DyCIST) is a proposed token standard that extends ERC-1155 and combines its functionality with other existing token standards, introducing unique features for interoperability, cross-chain operation, and token wrapping.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 30, 2023

File ERCS/erc-7518.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Add ERC: Dynamic Compliant Interop Security Token #7518 Add ERC: Dynamic Compliant Interop Security Token Oct 31, 2023
@github-actions github-actions bot removed the w-ci label Oct 31, 2023
@github-actions github-actions bot added the w-ci label Oct 31, 2023
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

ERCS/erc-7518.md Outdated
Comment on lines 15 to 19
[ERC-7518](./eip-7518.md) is a proposed token standard that extends [ERC-1155](./eip-1155.md) and combines its functionality with other existing token standards, introducing unique features for interoperability, cross-chain operation, and token wrapping. The standard aims to provide a flexible and efficient solution for managing real-asset security tokens. At its core, [ERC-7518](./eip-7518.md) introduces the concept of partitions, where each `tokenId` represents a distinct partition. A partition can have its own set of rights and privileges, making it suitable for various use cases, including but not limited to semi-fungible asset management.

One of the significant use cases of [ERC-7518](./eip-7518.md) is semi-fungible asset management, enabling the representation of different fractional ownership units within a single token. This facilitates the fractionalization of assets, allowing investors to own smaller portions of high-value assets. However, it is essential to note that `tokenId` can represent various partitions, each serving different purposes beyond share classes.

[ERC-7518](./eip-7518.md) addresses the need for enhanced cross-chain interoperability and flexible compliance management in the rapidly evolving landscape of security tokens. By leveraging the [ERC-7518](./eip-7518.md) standard, security tokens can seamlessly interact with the [ERC-7518](./eip-7518.md) ecosystem, enabling trustless transfers and integration with decentralized finance (DeFi) platforms.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "this proposal" instead of the number when talking about this document. Please make this change throughout, not just here.

Suggested change
[ERC-7518](./eip-7518.md) is a proposed token standard that extends [ERC-1155](./eip-1155.md) and combines its functionality with other existing token standards, introducing unique features for interoperability, cross-chain operation, and token wrapping. The standard aims to provide a flexible and efficient solution for managing real-asset security tokens. At its core, [ERC-7518](./eip-7518.md) introduces the concept of partitions, where each `tokenId` represents a distinct partition. A partition can have its own set of rights and privileges, making it suitable for various use cases, including but not limited to semi-fungible asset management.
One of the significant use cases of [ERC-7518](./eip-7518.md) is semi-fungible asset management, enabling the representation of different fractional ownership units within a single token. This facilitates the fractionalization of assets, allowing investors to own smaller portions of high-value assets. However, it is essential to note that `tokenId` can represent various partitions, each serving different purposes beyond share classes.
[ERC-7518](./eip-7518.md) addresses the need for enhanced cross-chain interoperability and flexible compliance management in the rapidly evolving landscape of security tokens. By leveraging the [ERC-7518](./eip-7518.md) standard, security tokens can seamlessly interact with the [ERC-7518](./eip-7518.md) ecosystem, enabling trustless transfers and integration with decentralized finance (DeFi) platforms.
This proposal is a proposed token that extends [ERC-1155](./eip-1155.md) and combines its functionality with other existing token standards, introducing unique features for interoperability, cross-chain operation, and token wrapping. The standard aims to provide a flexible and efficient solution for managing real-asset security tokens. At its core, This proposal introduces the concept of partitions, where each `tokenId` represents a distinct partition. A partition can have its own set of rights and privileges, making it suitable for various use cases, including but not limited to semi-fungible asset management.
One of the significant use cases of this proposal is semi-fungible asset management, enabling the representation of different fractional ownership units within a single token. This facilitates the fractionalization of assets, allowing investors to own smaller portions of high-value assets. However, it is essential to note that `tokenId` can represent various partitions, each serving different purposes beyond share classes.
This proposal addresses the need for enhanced cross-chain interoperability and flexible compliance management in the rapidly evolving landscape of security tokens. By leveraging this proposal standard, security tokens can seamlessly interact with this proposal ecosystem, enabling trustless transfers and integration with decentralized finance (DeFi) platforms.

ERCS/erc-7518.md Outdated Show resolved Hide resolved
ERCS/erc-7518.md Outdated
Comment on lines 581 to 590
In addition to the compatibility with [ERC-1155](./eip-1155.md), [ERC-7518](./eip-7518.md) introduces unique features specifically tailored for security tokens. These features include:

* Enhanced cross-chain interoperability: [ERC-7518](./eip-7518.md) enables security tokens to seamlessly interact with the [ERC-7518](./eip-7518.md) ecosystem, allowing for trustless transfers and integration with DeFi platforms across different blockchain networks.
* Semi-fungible share class management: [ERC-7518](./eip-7518.md) supports the management of semi-fungible share classes, providing flexibility in the representation of ownership and fractional shares of real-world assets.
* Token wrapping: [ERC-7518](./eip-7518.md) introduces token wrapping functionality, enabling the conversion of tokens from one standard to another, further enhancing interoperability and integration with various blockchain networks.
* Flexible compliance management: [ERC-7518](./eip-7518.md) offers a comprehensive compliance management solution, including off-chain verification, custom rules, regulations, and signature validation. This ensures that security tokens adhere to the necessary regulatory requirements while maintaining a high level of flexibility.
* Hard Asset such as Commercial Tower: [ERC-7518](./eip-7518.md) can be used to tokenize a commercial tower, allowing investors to own a fraction of the asset. Each `tokenId` can represent a unique share class, such as a percentage of the entire tower or individual floors. This enables greater liquidity and accessibility to real estate investments, as smaller investors can participate in owning a portion of a large commercial property
* Soft Asset such as Funds: [ERC-7518](./eip-7518.md) can be used to tokenize funds, especially in a Fund of Funds (FoF) business model. Each sub-fund within the FoF can be tokenized, with each `tokenId` representing a unique share class. This allows investors to directly invest in specific sectors, regions, or strategies based on their preferences. The semi-fungible share class management feature of [ERC-7518](./eip-7518.md) provides the flexibility to create and manage multiple share classes with varying rights and privileges.

By incorporating these additional features, [ERC-7518](./eip-7518.md) addresses the growing need for enhanced cross-chain interoperability and flexible compliance management in the rapidly evolving landscape of security tokens. This makes [ERC-7518](./eip-7518.md) a powerful and versatile token standard for the security token ecosystem.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These points aren't exactly relevant to backwards compatibility. They are more motivating examples, and could be put in the motivation section.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@SamWilsn
Copy link
Collaborator

SamWilsn commented Feb 2, 2024

I'm facing an issue with referencing EIP-712, which resides in a separate repository, and I'm unable to create a relative reference path to it. As a result, the EIP Validator check is failing. I'm uncertain about the solution to this problem.

You can use [EIP-712](./eip-712.md) and it'll work.

@github-actions github-actions bot removed the w-stale label Feb 3, 2024
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot removed the w-stale label Mar 12, 2024
ERCS/erc-7518.md Outdated Show resolved Hide resolved
ERCS/erc-7518.md Outdated Show resolved Hide resolved
ERCS/erc-7518.md Outdated Show resolved Hide resolved
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@SamWilsn
Copy link
Collaborator

Looks like there's still a few outstanding eipw messages on this. You'll need to correct those before this can merge.

@github-actions github-actions bot removed the w-ci label Apr 18, 2024
Copy link

The commit 1069da4 (as a parent of 017b2fc) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Apr 18, 2024
function forceTransfer(address from,address to,uint256 id,uint256 amount,bytes memory data) external returns (bool);
```

* MUST bypasses normal transfer restrictions and authorization checks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* MUST bypasses normal transfer restrictions and authorization checks.
* MUST bypass normal transfer restrictions and authorization checks.

* MUST bypasses normal transfer restrictions and authorization checks.
* MUST revert if the `from` address is not Frozen.
* MUST revert if `to` address is Frozen.
* MUST only authorized entities have the capability to call this function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* MUST only authorized entities have the capability to call this function.
* MUST ensure that only authorized entities have the capability to call this function.

Send payouts to single address, receiver will be receiving a specific amount of tokens.

```solidity
function Payout(address calldata to,uint256 calldata amount) public returns (bool)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function Payout(address calldata to,uint256 calldata amount) public returns (bool)
function payout(address calldata to,uint256 calldata amount) public returns (bool)

possibly?

type: Standards Track
category: ERC
created: 2023-09-14
requires: 165, 1155
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires: 165, 1155
requires: 165, 1155, 3643

To understand the section around line 347, I think ERC-3643 is required reading.

---
eip: 7518
title: Dynamic Compliant Interop Security Token
description: A security token contract utilizing semi fungible partitioning focusing on dynamic compliance and interoperability.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this token compliant with? What does it interoperate with? What is a partition? What makes it dynamic?

Your description raises a lot of questions without really describing your standard well.

Two small suggestions are: don't repeat your title as much (that'll give you more room to include useful content here), and highlight the "core" of the proposal you mention in the abstract:

Suggested change
description: A security token contract utilizing semi fungible partitioning focusing on dynamic compliance and interoperability.
description: Group security tokens into partitions with rights/privileges for cross-chain interoperability and compliance management

This is only a suggestion. I don't understand all the specifics of your proposal, so do what you will here!

Extends and combines the functionalities of existing token standards like [ERC-1155](./eip-1155.md), addressing the unique requirements of security tokens, such as cross-chain interoperability, flexible compliance management, and token wrapping.
* Enhancing Interoperability and Compliance Management:

The proposal introduces unique features for cross-chain operations, semi-fungible share class management, and seamless interaction with the proposal ecosystem. It also provides a comprehensive compliance model for both on-chain and off-chain verification, ensuring adherence to various regulatory requirements and jurisdictional restrictions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph isn't explaining the "why" of anything. The Rationale section should explain technical choices made within the proposal.

For example, if you were writing a proposal to build a tool shed, that proposal's Rationale section could explain why you chose wooden siding over vinyl.

Comment on lines +547 to +552
* Enhanced cross-chain interoperability: [ERC-7518](./eip-7518.md) enables security tokens to seamlessly interact with the [ERC-7518](./eip-7518.md) ecosystem, allowing for trustless transfers and integration with DeFi platforms across different blockchain networks.
* Semi-fungible share class management: [ERC-7518](./eip-7518.md) supports the management of semi-fungible share classes, providing flexibility in the representation of ownership and fractional shares of real-world assets.
* Token wrapping: [ERC-7518](./eip-7518.md) introduces token wrapping functionality, enabling the conversion of tokens from one standard to another, further enhancing interoperability and integration with various blockchain networks.
* Flexible compliance management: [ERC-7518](./eip-7518.md) offers a comprehensive compliance management solution, including off-chain verification, custom rules, regulations, and signature validation. This ensures that security tokens adhere to the necessary regulatory requirements while maintaining a high level of flexibility.
* Hard Asset such as Commercial Tower: [ERC-7518](./eip-7518.md) can be used to tokenize a commercial tower, allowing investors to own a fraction of the asset. Each `tokenId` can represent a unique share class, such as a percentage of the entire tower or individual floors. This enables greater liquidity and accessibility to real estate investments, as smaller investors can participate in owning a portion of a large commercial property
* Soft Asset such as Funds: [ERC-7518](./eip-7518.md) can be used to tokenize funds, especially in a Fund of Funds (FoF) business model. Each sub-fund within the FoF can be tokenized, with each `tokenId` representing a unique share class. This allows investors to directly invest in specific sectors, regions, or strategies based on their preferences. The semi-fungible share class management feature of [ERC-7518](./eip-7518.md) provides the flexibility to create and manage multiple share classes with varying rights and privileges.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make it more clear what these features are backwards (in)compatible with? This just looks like a list of features of this proposal.

Copy link

github-actions bot commented May 7, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants