Add ERC: Transient ERC-20 Approvals #81
Conversation
eip-review-bot
changed the title
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
There was a problem hiding this comment.
Please rename the file to ERCS/erc-7550.md.
|
|
||
| `transientAllowance`, `transientApprove`, and `TransientApproval` function identically to `allowance`, `approve`, `Approval` respectively, with the caveats that: | ||
| - `transientAllowance` is uses EIP-1153 transient storage to track transient approvals | ||
| - tokens SHOULD exclusively exhaust the transient allowance before checking or using the persistent allowance for `transferFrom`. |
There was a problem hiding this comment.
You should define "persistent allowance" (presumably as the traditional ERC-20 allowance.)
| title: Transient ERC-20 Approvals | ||
| description: Transient ERC-20 approvals via function calls and EIP-712 secp256k1 signatures | ||
| author: Joey Santoro (@joeysantoro), Moody Salem (@moodysalem) | ||
| discussions-to: TODO |
There was a problem hiding this comment.
Since you don't have a discussions thread, I'll leave this comment here:
Would it be possible to support ERC-1271 signatures as well? Probably not the most necessary addition, but if it isn't too hard, it could be worth it.
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
The commit 78713d8 (as a parent of 0713e70) contains errors. |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: