Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Single Sign-On for Account Discovery #99
base: master
Are you sure you want to change the base?
Add ERC: Single Sign-On for Account Discovery #99
Changes from 13 commits
559c658
5b41011
7f595c8
057b915
ffcb995
bfb8f44
9b57954
8d12541
8cdf8d2
b1867bc
9ab54c1
fa0dc00
00637a5
4177534
db51ce8
9c9a582
f54218d
8ba9f7f
2878e73
c529934
e039598
d452225
e9c13a2
166ede7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 4 in ERCS/erc-7555.md
GitHub Actions / EIP Walidator
preamble header `description` should not contain `standard` (or similar words.)
Check failure on line 6 in ERCS/erc-7555.md
GitHub Actions / EIP Walidator
preamble header `discussions-to` should point to a thread on ethereum-magicians.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a suggestion than a hard requirement for merging, but I think providing an overview section that describes how everything works would be much appreciated.
Check failure on line 56 in ERCS/erc-7555.md
GitHub Actions / EIP Walidator
non-relative link or image
Check failure on line 57 in ERCS/erc-7555.md
GitHub Actions / EIP Walidator
non-relative link or image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik SIWE doesn't supper eip 6492 atm which seems potentially problematic for 4337 accounts
having said that, I don't see how manually calling the
redirect_url
with a spoofed address could accomplish anything malicious. Ultimately dispatching a txn depends on the provider/sendTransaction
endpoint which can't be spoofed unless I'm missing somethingCheck failure on line 169 in ERCS/erc-7555.md
GitHub Actions / EIP Walidator
non-relative link or image