Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trio #73

Merged

Conversation

pipermerriam
Copy link
Member

What was wrong?

Using very old trio version

How was it fixed?

Updated dependency versions

Cute Animal Picture

omnomnom

setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what other landmines might be under the hood, but looks fine to me. (minus the constraint issue)

setup.py Outdated
@@ -63,8 +63,8 @@
include_package_data=True,
install_requires=[
"async-generator>=1.10,<2",
"trio>=0.13,<14",
"trio-typing>=0.3,<0.4",
"trio>=0.16,<17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"trio>=0.16,<17",
"trio>=0.16,<0.17",

@pipermerriam pipermerriam merged commit 4758e92 into ethereum:master Sep 4, 2020
@pipermerriam pipermerriam deleted the piper/update-trio-dependency branch September 4, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants