add LightClientHeader wrapper
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data). There is a minor change to the JSON serialization, where the `header` properties are now nested inside a `LightClientHeader`. The SSZ serialization remains compatible. See ethereum/consensus-specs#3190
|
(This one should only be merged if ethereum/consensus-specs#3190 gets accepted). |
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jan 9, 2023
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data). There is a minor change to the JSON serialization, where the `header` properties are now nested inside a `LightClientHeader`. The SSZ serialization remains compatible. See ethereum/consensus-specs#3190 and ethereum/beacon-APIs#287
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jan 12, 2023
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data). There is a minor change to the JSON serialization, where the `header` properties are now nested inside a `LightClientHeader`. The SSZ serialization remains compatible. See ethereum/consensus-specs#3190 and ethereum/beacon-APIs#287
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jan 12, 2023
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data). There is a minor change to the JSON serialization, where the `header` properties are now nested inside a `LightClientHeader`. The SSZ serialization remains compatible. See ethereum/consensus-specs#3190 and ethereum/beacon-APIs#287
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jan 13, 2023
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data). There is a minor change to the JSON serialization, where the `header` properties are now nested inside a `LightClientHeader`. The SSZ serialization remains compatible. See ethereum/consensus-specs#3190 and ethereum/beacon-APIs#287
|
ick i didnt follow my own suggestion and ask for this to be added to change log :/ |
|
Already is listed, the change is for an API that was not yet part of a release. In CHANGES.md, I noticed just now though that they incorrectly refer to |
|
ah ok, that'll be my fault, i did a huge batch to get changes started |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The light client data structures were changed to accommodate additional fields in future forks (e.g., to also hold execution data).
There is a minor change to the JSON serialization, where the
headerproperties are now nested inside aLightClientHeader. The SSZ serialization remains compatible.See ethereum/consensus-specs#3190