Add checks that field elements are canonical #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm bindings are failing here, might need to ping the respective code owners about making sure the blobs are actually canonical and not just random bytes |
Once this PR is rebased, I can work on fixing the java bindings. Think only the pointEvaluation test needs fixing. All random blobs are canonical in the java tests after the last PR. |
xrchz
force-pushed
the
check_encodings
branch
from
63b3215
to
6474125
Compare
We ensure we are below the modulus by just using a zero final byte for each field element encoding. In the test, I do not understand why changing the final (zero) byte causes verification to succeed instead of failing. But this is why the change is now to the first byte.
xrchz
force-pushed
the
check_encodings
branch
from
6474125
to
4101648
Compare
Align C# tests with the modulus check
Do not allow blob fields to overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11