Support for Windows cross-compilation from Linux #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
force-pushed
the
windows-cross-compilation
branch
from
e6ed999
to
734ab4d
Compare
asn-d6
reviewed
Apr 27, 2023
Since `DirSep` matches the default separator of the target OS, it's not suitable for performing path operations during compile-time on the host OS. The particular fix here solves the issue for cross-compiling a Windows build from a Linux host, but Nim seems to need a more general solution for detecting the host OS during compilation, so a host OS specific separator can be used in paths derived from `currentSourcePath`.
zah
force-pushed
the
windows-cross-compilation
branch
from
734ab4d
to
a31090c
Compare
jtraglia
reviewed
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
DirSepmatches the default separator of the target OS, it's not suitable for performing path operations during compile-time on the host OS.The particular fix here solves the issue for cross-compiling a Windows build from a Linux host, but Nim seems to need a more general solution for detecting the host OS during compilation, so a host OS specific separator can be used when deriving paths from
currentSourcePath.