Make from_hex() safer in rust bindings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM but let's also get @divagant-martian or @pawanjay176 to check it out. |
pawanjay176
approved these changes
May 26, 2023
|
121c6bb LGTM. I will wait for @divagant-martian and @pawanjay176 to take a look as well before merging. (Accidentally misclicked and closed the PR. Reopened it) |
divagant-martian
approved these changes
May 28, 2023
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so
from_hexcannot panic. Previously, it would panic if the string were fewer than 2 bytes or the hex was invalid. This makes the "0x" optional, which is more user friendly IMO; like the Go bindings.