Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Ckzg.Bindings to become 0.4.0 #378

Merged
merged 1 commit into from
Oct 20, 2023
Merged

C# Ckzg.Bindings to become 0.4.0 #378

merged 1 commit into from
Oct 20, 2023

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Oct 20, 2023

No description provided.

@flcl42 flcl42 requested a review from jtraglia October 20, 2023 10:45
jtraglia
jtraglia approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But is there a better long-term solution for this?

@jtraglia jtraglia merged commit af4e805 into main Oct 20, 2023
34 checks passed
@jtraglia jtraglia deleted the csharp-inc-ver branch October 20, 2023 12:40
@flcl42
Copy link
Contributor Author

flcl42 commented Oct 20, 2023

LGTM. But is there a better long-term solution for this?

Yes it's possible to improve. I'd try to do the following:

  • use the latest tag for x.y.z in x.y.z.t;
  • use a counter variable that resets on new tag for t in x.y.z.t;
  • maybe publish on demand only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flcl42 @jtraglia