Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose compute_kzg_proof #80

Merged
merged 14 commits into from
Jan 24, 2023
Merged

Expose compute_kzg_proof #80

merged 14 commits into from
Jan 24, 2023

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Jan 23, 2023

This exposes the compute_kzg_proof in the way described here:

This PR will:

  • Replace BLSFieldElement with Bytes32 in many places.
    • These are not guaranteed to be valid field elements and what I did before was misleading. Sorry.
  • Add compute_kzg_proof to the readme.
    • Also sort the entries in a more logical order.
  • Create compute_kzg_proof_impl and move bulk of work there.
    • This allows us to pass a polynomial to it from compute_aggregate_kzg_proof.
  • Use f->bytes for calls to bytes_to_g1 & bytes_to_bls_field.
    • This is a lot cleaner in my opinion.

Fixes #34.

@jtraglia
Copy link
Member Author

So I just learned that I changed some things I shouldn't have and it no longer matches the spec. Let me fix those things and then it will be ready for review. Sorry.

@asn-d6
Copy link
Contributor

asn-d6 commented Jan 24, 2023

Let's not merge this just yet. Actively workign on it.

@jtraglia
Copy link
Member Author

Okay I think this is ready now. Please review.

@xrchz xrchz merged commit 8907fbc into ethereum:main Jan 24, 2023
@jtraglia jtraglia deleted the expose-compute-kzg-proof branch January 24, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose compute_kzg_proof in interface
3 participants